Package: rgbpaint / 0.8.7-5

Metadata

Package Version Patches format
rgbpaint 0.8.7-5 3.0 (quilt)

Patch series

view the series file
Patch File delta Description
01 install_paths.diff | (download)

configure | 6 3 + 3 - 0 !
doc/Makefile | 6 3 + 3 - 0 !
po/Makefile | 6 3 + 3 - 0 !
src/Makefile | 6 3 + 3 - 0 !
4 files changed, 12 insertions(+), 12 deletions(-)

 implement standard installation path modifiers.
 The upstream source has a build system that polutes file paths
 with quotation marks. This is inappropriate for UNIX systems,
 and it interferes with the next alteration.
 .
 Introduce a standard prefix DESTDIR for installation paths.
02 build_system_and_bashisms.diff | (download)

configure | 35 20 + 15 - 0 !
src/Makefile | 3 3 + 0 - 0 !
2 files changed, 23 insertions(+), 15 deletions(-)

 tidy configure script and install a program icon.
 Insert an explicit shebang in the configure script.
 .
 Remove some immediate bashisms in test conditionals.
 Thus the script works with Dash.
 .
 Output a variable PREFIX into the configurator `_conf.txt'.
 This makes it possible to install a program icon, existent
 in the source archive, into `$PREFIX/share/pixmaps/'.
03 swedish_po_file.diff | (download)

po/Makefile | 2 1 + 1 - 0 !
po/sv.po | 182 182 + 0 - 0 !
2 files changed, 183 insertions(+), 1 deletion(-)

 contruct a missing translation for swedish.
 The upstream has a limited supply of translations for the
 Gettext subsystem. The lack of Swedish is particularly felt!
04 manpage.diff | (download)

doc/_rgbpaint.1 | 12 6 + 6 - 0 !
1 file changed, 6 insertions(+), 6 deletions(-)

 lintian warnings regarding hyphenation in manual page.
05 compiler_warnings.diff | (download)

src/memory.c | 6 3 + 3 - 0 !
src/memory.h | 2 1 + 1 - 0 !
src/png.c | 2 1 + 1 - 0 !
src/toolbar.c | 10 5 + 5 - 0 !
4 files changed, 10 insertions(+), 10 deletions(-)

 resolve compiler warnings.
 In `png.c' a buffer size is incorrectly set.
 .
 Signedness discrepancies are covered in `memory.h', `memory.c',
 and `toolbar.c'.
06 castings_for_amd64.diff | (download)

src/canvas.c | 18 10 + 8 - 0 !
src/mainwindow.c | 3 2 + 1 - 0 !
src/mygtk.c | 4 2 + 2 - 0 !
src/otherwindow.c | 6 3 + 3 - 0 !
src/toolbar.c | 18 11 + 7 - 0 !
5 files changed, 28 insertions(+), 21 deletions(-)

 type castings for 64 bit systems.
 A handful source files are using pointers to convey integer data.
 These need to be cast into `long int' in order to pass silently
 also for systems based on 64 bit architectures.
07 option_handling.diff | (download)

src/main.c | 82 61 + 21 - 0 !
1 file changed, 61 insertions(+), 21 deletions(-)

 inferior option handling leads to segfaults.
 The sequential testing of command line options is easily
 provoked into producing segmentation faults. Leaving an
 option whithout the expected argument is sufficient.
 .
 Argument sanitation and short circuits in the loop
 constitute a satisfactory cure.
08 fallback_icons_and_size.diff | (download)

src/toolbar.c | 21 19 + 2 - 0 !
1 file changed, 19 insertions(+), 2 deletions(-)

 prefer fallback icons when possible.
 When the program was given the option `-svg' for
 importing task icons, icons missing in the imported
 set could be replaced by the non-expressive pencil icon,
 forgetting the actual purpose of the particular image.
 Only those cases where the default setting was using
 the stock GTK icons were ever touched by this behaviour.
 .
 Now the GTK stock icon is recovered, should no new icon
 be imported for a particular action, and there be no
 icon tailored by rgbPaint to replace it.
 .
 In addition, any imported icon is scaled to a size that exactly
 agrees with the default icons, thus preserving appearances
09 make_background_transparent.diff | (download)

src/graphics/icon.xpm | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 program icon with transparent background.
 The originally black background is made transparent.
10 fix_lib_underlinkage.diff | (download)

src/Makefile | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 missing linkage, ftbfs with clang.
 A missing linker directive to use libm leads
 to build failure with llvm/clang.
11 hardening_errors.diff | (download)

configure | 10 6 + 4 - 0 !
src/Makefile | 3 2 + 1 - 0 !
src/viewer.c | 6 3 + 3 - 0 !
3 files changed, 11 insertions(+), 8 deletions(-)

 ftbfs with hardened builds
 The enforcement of hardened builds uncovers
 a small number of errors:
 .
 Possibly tainted format strings.
 .
 Build system disregards CPPFLAGS during compilation.
12 build_portability.diff | (download)

configure | 4 2 + 2 - 0 !
1 file changed, 2 insertions(+), 2 deletions(-)

 build failures.
 Ignore a missing '_conf.txt' while cleaning.
 .
 Do not assume Gcc to be the active compiler.
 Check $CC and use 'cc' as default. This will
 hopefully manage also 'clang'.