Package: liblognorm / 2.0.1-1.1

Metadata

Package Version Patches format
liblognorm 2.0.1-1.1 3.0 (quilt)

Patch series

view the series file
Patch File delta Description
0001 fix infinite loop in read_line.patch | (download)

src/lognormalizer.c | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 [patch 1/3] fix infinite loop in read_line()

fgetc returns an int and we were using char to store the result. This is
not safe on certain architectures. As a result, the loop in
lognormalizer's read_line() function never finished.

GCC complained about this issue:

lognormalizer.c: In function 'read_line':
lognormalizer.c:185:10: warning: comparison is always false due to limited range of data type [-Wtype-limits]
   if (ch == EOF) break;
          ^~

Fix this by using type int instead of char.

Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=834121
Fixes: #217

0002 use proper type for OffsetHour in ln_parseRFC5424Dat.patch | (download)

src/parser.c | 2 1 + 1 - 0 !
src/v1_parser.c | 2 1 + 1 - 0 !
2 files changed, 2 insertions(+), 2 deletions(-)

 [patch 2/3] use proper type for offsethour in ln_parserfc5424date()

GCC spotted the following errors:

v1_parser.c: In function 'ln_parseRFC5424Date':
v1_parser.c:266:17: warning: comparison is always false due to limited range of data type [-Wtype-limits]
   if(OffsetHour < 0 || OffsetHour > 23)
                 ^

parser.c: In function 'ln_v2_parseRFC5424Date':
parser.c:227:17: warning: comparison is always false due to limited range of data type [-Wtype-limits]
   if(OffsetHour < 0 || OffsetHour > 23)
                 ^

Fix it by using type int for OffsetHour.

0003 fix misleading indentation warnings with GCC6.patch | (download)

src/v1_samp.c | 8 4 + 4 - 0 !
1 file changed, 4 insertions(+), 4 deletions(-)

 [patch 3/3] fix misleading indentation warnings with gcc6

v1_samp.c had mixed tabs and spaces indentation which GCC 6 complains
about:

v1_samp.c: In function 'ln_v1_processSamp':
v1_samp.c:764:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
     if(getLineType(buf, lenBuf, &offs, &typeStr) != 0)
     ^~
v1_samp.c:767:2: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
  if(!es_strconstcmp(typeStr, "prefix")) {
  ^~

Fix by using tabs consistently in that function.