Package: kitemmodels / 5.28.0-2

Metadata

Package Version Patches format
kitemmodels 5.28.0-2 3.0 (quilt)

Patch series

view the series file
Patch File delta Description
Fix assert in beginRemoveRows when deselecting an empty c.patch | (download)

autotests/kselectionproxymodeltest.cpp | 14 14 + 0 - 0 !
src/kselectionproxymodel.cpp | 6 3 + 3 - 0 !
2 files changed, 17 insertions(+), 3 deletions(-)

 fix assert (in beginremoverows) when deselecting an empty child of a
 selected child in korganizer

After
   int proxyEndRemove = proxyStartRemove;
   proxyEndRemove += rc; was adding 0 (empty root)
and then --proxyEndRemove; was making us end up with proxyEndRemove < proxyStartRemove.

REVIEW: 129657

KExtraColumnsProxyModel Persist model indexes after emitt.patch | (download)

src/kextracolumnsproxymodel.cpp | 29 15 + 14 - 0 !
1 file changed, 15 insertions(+), 14 deletions(-)

 kextracolumnsproxymodel: persist model indexes after emitting
 layoutChange, not before

Same fix as Stephen Kelly's fix for QIdentityProxyModel in https://codereview.qt-project.org/180390

I tried to write a unittest but QStandardItemModel doesn't support moveRow,
and we don't have all the infrastructure here to force emitting a layoutChange
with specific parents like in the Qt unittests.

This commit, added to the 3 fixes in Qt, fixes crashes when moving folders in kmail.

CCMAIL: steveire@gmail.com

Update proxies for recently realised class of bugs.patch | (download)

src/kconcatenaterowsproxymodel.cpp | 22 11 + 11 - 0 !
src/kdescendantsproxymodel.cpp | 4 2 + 2 - 0 !
src/kselectionproxymodel.cpp | 18 9 + 9 - 0 !
3 files changed, 22 insertions(+), 22 deletions(-)

 update proxies for recently realised class of bugs.

Store persistent indexes for updating after emitting any signals which
can invoke user code.