Package: hiredis / 0.13.3-2

Metadata

Package Version Patches format
hiredis 0.13.3-2 3.0 (quilt)

Patch series

view the series file
Patch File delta Description
01_use proper destdir.patch | (download)

Makefile | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)

 make the makefile use the $(destdir) variable
02_disable failing test.patch | (download)

test.c | 4 2 + 2 - 0 !
1 file changed, 2 insertions(+), 2 deletions(-)

 disable "returns error when the port is not open" test
 This patch disables the test "Returns error when the port is not open"
 because it is failing on some architectures (kfreebsd-* and hurd-i386).
04_disable network tests.patch | (download)

test.c | 4 4 + 0 - 0 !
1 file changed, 4 insertions(+)

 disable "returns error when host cannot be resolved"
 This patch disables a test that relies on the presence of a
 network connection.
06_redis startup.patch | (download)

Makefile | 6 6 + 0 - 0 !
1 file changed, 6 insertions(+)

 fix race creating unix socket in tests.
  There seems to be a race between the Redis server strarting up and
  the unix socket test. This gives redis a little more time to create
  the socket file.
07_cmake.patch | (download)

HiredisConfig.cmake.in | 5 5 + 0 - 0 !
HiredisConfigVersion.cmake.in | 22 22 + 0 - 0 !
Makefile | 17 16 + 1 - 0 !
3 files changed, 43 insertions(+), 1 deletion(-)

---
08_kfreebsd_ftbfs.patch | (download)

fmacros.h | 4 1 + 3 - 0 !
1 file changed, 1 insertion(+), 3 deletions(-)

 fix ftbfs due to strerror_r on kfreebsd
 Defining _XOPEN_SOURCE=1 causes strange behavior on Debian kfreebsd
 archs (i.e. GNU userspace with FreeBSD kernel) when _GNU_SOURCE is not
 defined.

 Not sure I fully understand the bizarre semantics, but it seems to
 use the XSI-compliant interface
 (int strerror_r(int, char*, size_t)) but the GNU implementation
 (char *strerror_r(int, char*, size_t)) such that strerror_r returns
 32-bits of a 64-bit char * on x86_64 kfreebsd. We would expect
 strerror_r to return zero when using the XSI-compliant strerror_r
 implementation or a 64-bit char* when using the GNU version. Instead,
 we get something in between!

 Unless I'm missing something, being more explicit about what version
 of _XOPEN_SOURCE we want seems to be the prudent thing to do here --
 and if folks want the GNU implementation of strerror_r for some reason
 they can always -D_GNU_SOURCE explicitly.
09_fix_test_race.patch | (download)

net.c | 39 28 + 11 - 0 !
test.c | 4 2 + 2 - 0 !
2 files changed, 30 insertions(+), 13 deletions(-)

 fix potential race in "invalid timeout" tests
 Prior to this change it was possible for the tests checking invalid timeout
 values to successfully connect & thus never trigger the underlying error.
 We prefer to fail early rather than risk unpredictable behavior.